Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce io.quarkus.code.java-version config #1056

Closed
wants to merge 2 commits into from

Conversation

gastaldi
Copy link
Collaborator

@gastaldi gastaldi commented Oct 10, 2022

This PR introduces a io.quarkus.code.java-version config property that allows setting the default Java version to be used.

It allows us to set the production instance to use JDK 11 by default as requested in https://issues.redhat.com/browse/QUARKUS-2451

@gastaldi gastaldi requested a review from ia3andy October 10, 2022 22:37
@github-actions
Copy link

github-actions bot commented Oct 10, 2022

🙈 The PR is closed and the preview is expired.

This allows setting a default java version in the deployment descriptor

Use javaVersion in frontend

Add IO_QUARKUS_CODE_JAVA_VERSION to OpenShift template
@gastaldi gastaldi force-pushed the default_java_version branch from 2015b01 to 802dd74 Compare October 11, 2022 00:19
@ia3andy
Copy link
Collaborator

ia3andy commented Oct 11, 2022

I am not sure this would be a good idea:

  • it introduces a public field that we need to maintain
  • it's not yet used by the rest clients (IDEs)
  • it won't be compatible and possibly conflict if we decide to have different default JDKs depending on the platform

@gastaldi
Copy link
Collaborator Author

  • it introduces a public field that we need to maintain

Not sure what you mean here, it's an optional value and a config property just like the others

  • it's not yet used by the rest clients (IDEs)

Of course not, this is a new feature :)

  • it won't be compatible and possibly conflict if we decide to have different default JDKs depending on the platform

Yes, this is a workaround until quarkusio/quarkus#28497 is implemented

Anyway, if the intention is to wait until the above issue is implemented, I am fine with closing this PR

@ia3andy
Copy link
Collaborator

ia3andy commented Oct 14, 2022

I am closing this as it has been decided that having a "static" java version is not the way forward.

Instead we should have this coming from the registry per stream:

  • Available JDKs
  • Default JDK

@ia3andy ia3andy closed this Oct 14, 2022
@gastaldi gastaldi deleted the default_java_version branch October 21, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants