Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VaultToken.cached incorrectly extends the tokens lifetime #262

Closed
kdubb opened this issue Apr 9, 2024 · 0 comments · Fixed by #263
Closed

VaultToken.cached incorrectly extends the tokens lifetime #262

kdubb opened this issue Apr 9, 2024 · 0 comments · Fixed by #263

Comments

@kdubb
Copy link
Contributor

kdubb commented Apr 9, 2024

This should only update the cached field but inadvertently updates the parent VaultTimeLimited.created field as well.

This creates tokens with expiration times that do not agree with Vault; therefore, the client can attempt to use expired tokens.

From discussion #261
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update VaultToken.cached to only update the cached field and nothing else kdubb/quarkus-vault
1 participant
@kdubb