Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable release #26

Closed
kucharzyk opened this issue Jan 17, 2024 · 10 comments
Closed

Stable release #26

kucharzyk opened this issue Jan 17, 2024 · 10 comments

Comments

@kucharzyk
Copy link

quarks-playwright is working very well in my application - it's stable and not causing any issues.
But version 0.0.1 indicates its early stage of experimental plugin that might be not developed in the future.

Do you have any plans to mark it as stable and release version 1.0.0?

@kucharzyk
Copy link
Author

This extension should be also published and visible on code.quarkus.io

@melloware
Copy link
Contributor

@kucharzyk yep they were waiting on a Quarkus Core fix to allow this library to be published as a testing only library.

@ia3andy
Copy link
Contributor

ia3andy commented Jan 25, 2024

I guess next version can be 1.0.0 and stable.

@ia3andy ia3andy closed this as completed May 21, 2024
@melloware
Copy link
Contributor

@ia3andy can this be listed on Extensions docs now have they fixed the issue with Test only components? If so I can work on updating the Dev UI Card for this if it will also be able to listed in the DevUI as an extension?

@ia3andy
Copy link
Contributor

ia3andy commented May 21, 2024

@melloware no, there is no easy way to allow this to be shown as an extension, because it's not an extension per say. Maybe we need to find a way for them to be in the registry as tooling dependencies or something..

cc @aloubyansky @gastaldi

@gastaldi
Copy link
Member

@ia3andy why not transform this into an extension? Regardless if it's used only in testing, making it an extension would solve all the issues around tooling AFAIK

@ia3andy
Copy link
Contributor

ia3andy commented May 21, 2024

@ia3andy why not transform this into an extension? Regardless if it's used only in testing, making it an extension would solve all the issues around tooling AFAIK

It's not possible, it won't compile, because of a restriction on dependencies

@melloware
Copy link
Contributor

@all-contributors add @kucharzyk for testing

Copy link
Contributor

@melloware

I've put up a pull request to add @kucharzyk! 🎉

@melloware
Copy link
Contributor

I have this working in this PR: #95 Playwright can be used in a normal app and not just for testing.

Gonna see if I can make it work in Native Mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants