Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler shutdown is not graceful: it does not wait all log to be sent #266

Open
vietk opened this issue Jul 12, 2024 · 0 comments
Open

Handler shutdown is not graceful: it does not wait all log to be sent #266

vietk opened this issue Jul 12, 2024 · 0 comments

Comments

@vietk
Copy link
Contributor

vietk commented Jul 12, 2024

When the log handler is being closed, the underlying HttpEventCollectorSender is closed as well.
However by default, the sender is only shutting down the executor service. It has two impacts :

  1. Queued logs will be not sent
  2. Some error log may arise when queued logs like this one Error while sending events to Splunk HEC: executor rejected java.io.InterruptedIOException: executor rejected

It's a valid use case that an application could try to send its logs during a certain period of time to ensure persistance in Splunk

Implementation idea :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant