Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question - is it required to add reflection-config entries for Firebase notification objects? #417

Closed
ygyg70 opened this issue Apr 19, 2023 · 3 comments
Labels
upsteam Issue on an upsteam library

Comments

@ygyg70
Copy link

ygyg70 commented Apr 19, 2023

Firebase notifications with native image didn't otherwise work.
Ended up adding entries for the following classes to reflection-config.json:
Message.class
Notification.class,
AndroidConfig.class,
AndroidNotification.class,
AndroidFcmOptions.class,
WebpushConfig.class,
WebpushFcmOptions.class,
WebpushNotification.class,
ApnsConfig.class,
ApnsFcmOptions.class,
ApsAlert.class,
FcmOptions.class,
MessagingServiceResponse.class

@loicmathieu
Copy link
Collaborator

@ygyg70 I don't understand the question.

Is there missing native image configuration for one of the extension in this repository ?

By the way, Google tries to manage native image configuration in each library, reflective access should be handle on their side so you can open an issue upstream so it will be available for everyone and not just Quarkus users

@ygyg70
Copy link
Author

ygyg70 commented Apr 21, 2023

@loicmathieu loicmathieu added the upsteam Issue on an upsteam library label Apr 21, 2023
@loicmathieu
Copy link
Collaborator

Great, I'll close it as dependabot will create an update PR when the issue is fixed upstream.
Please re-open it if something has to be done at our side except a dependency upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upsteam Issue on an upsteam library
Projects
None yet
Development

No branches or pull requests

2 participants