Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align dependencies with the Quarkus Platform BOM #105

Open
loicmathieu opened this issue Apr 9, 2021 · 2 comments
Open

Align dependencies with the Quarkus Platform BOM #105

loicmathieu opened this issue Apr 9, 2021 · 2 comments

Comments

@loicmathieu
Copy link
Collaborator

Most of our dependencies are comming from the Quarkus BOM or the Google Library BOM: https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM

@aloubyansky made a dependency convergence analysis and it appears that some dependencies are not aligned

114056965-7aee0b00-9892-11eb-9f64-c9b0d22fe7a3

We could migrate those dependencies, at least using the latests Google Library BOM, but maybe the issue is upsteamd (on Quarkus side) that should use the Google Library BOM.

@aloubyansky
Copy link
Member

I haven't looked into this further, if this is actually a misalignment compared to the quarkus-bom, it probably makes sense to align them going forward. But, just fyi, it's a part of the platform BOM generation process to align version constraints accross all the members. There typically will be adjustments. It depends on what the members bring in though. Which is why we need integration tests in the platform, to make sure the platform BOM works for every member.

@loicmathieu
Copy link
Collaborator Author

I think the best will be to use the Google Library BOM in Quarkus and uses the same version on GCS extensions.
On the library BOM readme, it is say this is the prefered way to manage GRPC / protobuf libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants