Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@NamedDynamoDbTable applicable to parameters would enable constructor injection #1408

Closed
scrocquesel opened this issue Sep 20, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@scrocquesel
Copy link
Member

Copy from quarkusio/quarkus#42647 (comment)

Description
Currently it is not possible to have

private final DynamoDbTable fooTable;

FooDao(@NamedDynamoDbTable("Foo") fooTable) {
this.fooTable = fooTable
}

Because @NamedDynamoDbTable is not applicable to method parameters. Would this be feasible?

Implementation ideas
No response

@scrocquesel scrocquesel added the enhancement New feature or request label Sep 20, 2024
@scrocquesel
Copy link
Member Author

@nicklasweasel For implementation ideas, you can wider the targets of the annotation and add support for them here

@nicklasweasel
Copy link

@nicklasweasel For implementation ideas, you can wider the targets of the annotation and add support for them here

Yep. There could be a static final "allowed kind" collection and then "if kind not in list then continue" which would get rid of the wide if in the loop. And then the allowed location of the annotation itself.

Any specific test one could use as basis for unit testing? And are there any basic docs on how to set up the development environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants