Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ubuntu version in Github Actions #348

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Conversation

95-martin-orion
Copy link
Collaborator

The ubuntu-16.04 environment is being turned down: actions/runner-images#3287

Once we confirm that this conversion is OK for TFQ, we will switch qsim over as well. Note that the python formatting workflow is not tied to TFQ and can therefore use the latest Ubuntu version without loss of generality.

@google-cla google-cla bot added the cla: yes Override CLA status to unblock PR. label May 19, 2021
@95-martin-orion
Copy link
Collaborator Author

From @MichaelBroughton: the TFQ version is currently locked to the TFQ toolchain here.

@MichaelBroughton
Copy link
Collaborator

xref: https://github.com/tensorflow/tensorflow/tree/master/third_party/toolchains/preconfig
TFQ relies on this toolchain for most builds and it is 16.04.

Copy link
Collaborator

@MichaelBroughton MichaelBroughton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As of TF 2.5.0, the toolchains have been upgraded and everyone is using 1 now. This should be good to go!

@95-martin-orion 95-martin-orion marked this pull request as ready for review August 13, 2021 14:39
@95-martin-orion 95-martin-orion merged commit af584c7 into master Aug 13, 2021
@95-martin-orion 95-martin-orion deleted the gha-ubuntu-bump branch August 13, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Override CLA status to unblock PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants