Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiAnd call graph returns x gates #1253

Open
mpharrigan opened this issue Aug 6, 2024 · 1 comment
Open

MultiAnd call graph returns x gates #1253

mpharrigan opened this issue Aug 6, 2024 · 1 comment

Comments

@mpharrigan
Copy link
Collaborator

In #1015 the callees of MultiAnd with not-all-ones control variables was changed. It used to propagate the cvs to the two bit And gates. Now it uses all And(cv1=1, cv2=1) gates and XGates. Was there a reason for this change? I would think philosophically that it can always be considered to use n And gates and those and gates might be hiding some cliffords; but really it would be architecture-dependent how the negative controls would be implemented in e.g. a surface code

cc @tanujkhattar

@mpharrigan
Copy link
Collaborator Author

The knock-on effect is this messes up the narrative of the call graph notebook / documentation which used MultiAnd as motivation for generalizer, so if we keep it as-is; that will need to be re-written

@mpharrigan mpharrigan added this to the v1.0 milestone Aug 8, 2024
@mpharrigan mpharrigan removed this from the v1.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant