Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable serialization of bloqs that store a sequence of sub-bloqs as an attribute #1125

Open
charlesyuan314 opened this issue Jul 11, 2024 · 0 comments

Comments

@charlesyuan314
Copy link
Contributor

To enable bloqs such as the Product block encoding to be serialized, we need to make changes to the serialization infrastructure:

To support serialization we'll have to update

int32 subbloq = 7;
to add a new NDArray subbloqs that stores an NDArray of integers corresponding to IDs of each of the subbloqs and then update
if isinstance(val, Bloq):
to check if the argument is an ndarray of bloqs, then delegate to a different method that serializes it.

Originally posted by @tanujkhattar in #1106 (comment)

@mpharrigan mpharrigan added this to the After v1.0 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants