Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddConstantMod --> ModAddK doesn't support simulation anymore #1046

Open
tanujkhattar opened this issue Jun 3, 2024 · 0 comments
Open

AddConstantMod --> ModAddK doesn't support simulation anymore #1046

tanujkhattar opened this issue Jun 3, 2024 · 0 comments
Labels
bloqs/arithmetic sim/quantum

Comments

@tanujkhattar
Copy link
Collaborator

https://github.com/quantumlib/Qualtran/pull/907/files#diff-d7e11e9a89cbedc95f75813093320217796e881bbb0d0427216aea88e86c7755 reorganized the modular arithmetic bloqs. As part of the organization, AddConstantMod was renamed to ModAddK and cirq.ArithmeticGate was removed as a base class.

This led to the bloqs not supporting simulation / tensor contraction anymore; which is bad because this bloq is used from PrepareHubbard and all other bloqs in the decomposition of hubbard model support simulation.

We should fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bloqs/arithmetic sim/quantum
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mpharrigan @tanujkhattar