Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

91 tests fail #851

Closed
yurivict opened this issue Oct 30, 2023 · 7 comments
Closed

91 tests fail #851

yurivict opened this issue Oct 30, 2023 · 7 comments
Assignees

Comments

@yurivict
Copy link

See the log.

Version: 1.6.0
Python-3.9
FreeBSD 13.2

@fdmalone
Copy link
Collaborator

Thanks for raising this. The tests that are failing are due to a bug in scipy #815. What version of scipy are you using? Was openfermion installed via pip?

@fdmalone fdmalone self-assigned this Oct 30, 2023
@fdmalone
Copy link
Collaborator

From here it looks like the additional upper limit on scipy isn't being pulled in from https://github.com/quantumlib/OpenFermion/blob/master/dev_tools/requirements/deps/runtime.txt.

@yurivict
Copy link
Author

We have scipy-1.11.1

OpenFermion was installed using the FreeBSD port, not pip.

@fdmalone
Copy link
Collaborator

How are your build dependencies pulled in? Do you manually edit the Makefile?
Or should these changes be pulled automatically from the openfermion requirements?

Screenshot 2023-10-30 at 10 42 33 AM

@yurivict
Copy link
Author

Unfortunately, in the context of the ports framework we can't pull arbitrary versions of dependencies, because the dependency packages have fixed versions.

This explains the problem, thank you.

We will wait for the fix in scipy then.

@fdmalone
Copy link
Collaborator

Ok, thanks for your understanding! I'll keep this open for the moment so we can track it.

@fdmalone
Copy link
Collaborator

@yurivict this scipy issue is now resolved so I will close this. I will cut a new patch release shortly and (hopefully) these test failures will disappear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants