-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate TaggedOperations
#4967
Comments
Note I tried this a while back and it's hugely invasive. For example Also since op classes aren't dataclasses, we need to bring in the |
Is this actually |
I think this is worth another discussion, especially given Dax's comments on how this is not as straightforward as it seems on face value. |
One option that may actually be easier is if we go all in and change all existing operations to gates. I've done a few of those for #4683. The ones remaining are those from #2626 (PauliString, QFT), and the higher level ones like CircuitOperation and ClassicallyControlledOperation. (POC for the former was working at #4725). If we do that, then GateOperation is all that's left. No inheritance hierarchy or anything. So we can simply add the tag to that class and be done. Still a lot of work to get to this point but I think it would result in a nice design. @95-martin-orion @tanujkhattar |
This is a large design issue and would require a considerable thought. Given that we are already past the threshold of considering large design items for Cirq 1.0, we should mark it as post 1.0 and work on it for Cirq 2.0. |
Description of the issue
Moved tags to the
Operation
classCirq version
master version
The text was updated successfully, but these errors were encountered: