Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build_proto ci check does not enforce that generated proto code is up to date #3087

Closed
maffoo opened this issue Jun 11, 2020 · 0 comments · Fixed by #3159
Closed

build_proto ci check does not enforce that generated proto code is up to date #3087

maffoo opened this issue Jun 11, 2020 · 0 comments · Fixed by #3159
Assignees
@balopat

Comments

@maffoo
Copy link
Contributor

maffoo commented Jun 11, 2020

We recently added cirq/google/api/v2/batch.proto and the ci check did not catch that generated code was not checked in. Original PR: #3064; follow-up to add generated code: #3086.
@balopat balopat self-assigned this Jul 21, 2020
@balopat balopat mentioned this issue Jul 21, 2020
Merged
CirqBot pushed a commit that referenced this issue Jul 21, 2020
@balopat
CI check for uncommitted generated proto files (#3159)
a16824f 
Fixes #3087.

demo: 
![Unnamed screen capture (1)](https://user-images.githubusercontent.com/635073/88002082-82784480-cab6-11ea-8374-6461da3e91c5.gif)
tonybruguier pushed a commit to tonybruguier/Cirq that referenced this issue Aug 23, 2020
@balopat
CI check for uncommitted generated proto files (quantumlib#3159)
edc95ef 
Fixes quantumlib#3087.

demo: 
![Unnamed screen capture (1)](https://user-images.githubusercontent.com/635073/88002082-82784480-cab6-11ea-8374-6461da3e91c5.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@balopat balopat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI check for uncommitted generated proto files balopat/Cirq
2 participants
@maffoo @balopat