Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove need to specify Gateset for Engine calls #2988

Closed
dabacon opened this issue May 8, 2020 · 3 comments
Closed

Remove need to specify Gateset for Engine calls #2988

dabacon opened this issue May 8, 2020 · 3 comments
Labels
area/gatesets area/google/engine area/google kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on

Comments

@dabacon
Copy link
Collaborator

dabacon commented May 8, 2020

It should be possible for a processor to know if it will support the given gates and the user not to have to specify the gate set. This might mean that it needs to query the device spec before hand. We could cache this (for sampler interfaces this could be done at construction time of the sampler). Branched off from #2819

@balopat balopat added area/gatesets area/google area/google/engine kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on labels Sep 18, 2020
@95-martin-orion
Copy link
Collaborator

@tanujkhattar is this complete? I remember Transformers removing some gateset-passing, but maybe not all of it.

@maffoo
Copy link
Contributor

maffoo commented Mar 28, 2022

We made gate_set optional for most engine calls in #4983. As a follow-up, we plan to deprecate and eventually remove the gate_set args (#4995) but since that's being tracked separately I think we can probably close this.

@dstrain115
Copy link
Collaborator

Closing this, as the direct issue (requiring gate set on calls) is complete and the remaining work is captured in other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gatesets area/google/engine area/google kind/feature-request Describes new functionality triage/accepted A consensus emerged that this bug report, feature request, or other action should be worked on
Projects
None yet
Development

No branches or pull requests

5 participants