From b977893c6cc75170a73445432b5138c9cdcaef7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Lefebvre?= Date: Thu, 28 Nov 2024 10:29:48 +0100 Subject: [PATCH] Remove sizeOnHide manual test as irrelevant MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Show and Hide two elements from a vertical layout, keeping the empty space when hidden. Remove sizeOnHide manual test as irrelevant. Change-Id: If833569099dbe7cf23cd06a9a768b1787c99de39 Reviewed-by: Richard Moe Gustavsen Reviewed-by: Thorbjørn Lund Martsum --- tests/manual/widgets/kernel/CMakeLists.txt | 1 - tests/manual/widgets/kernel/kernel.pro | 2 +- .../widgets/kernel/sizeonhide/CMakeLists.txt | 16 ---- .../manual/widgets/kernel/sizeonhide/main.cpp | 96 ------------------- .../widgets/kernel/sizeonhide/sizeonhide.pro | 3 - 5 files changed, 1 insertion(+), 117 deletions(-) delete mode 100644 tests/manual/widgets/kernel/sizeonhide/CMakeLists.txt delete mode 100644 tests/manual/widgets/kernel/sizeonhide/main.cpp delete mode 100644 tests/manual/widgets/kernel/sizeonhide/sizeonhide.pro diff --git a/tests/manual/widgets/kernel/CMakeLists.txt b/tests/manual/widgets/kernel/CMakeLists.txt index c3941510471..ea52cd84c1c 100644 --- a/tests/manual/widgets/kernel/CMakeLists.txt +++ b/tests/manual/widgets/kernel/CMakeLists.txt @@ -2,6 +2,5 @@ # SPDX-License-Identifier: BSD-3-Clause # add_subdirectory(qtooltip) # TODO: broken in dev -add_subdirectory(sizeonhide) add_subdirectory(layoutreplace) add_subdirectory(setscreen) diff --git a/tests/manual/widgets/kernel/kernel.pro b/tests/manual/widgets/kernel/kernel.pro index 236c9ff9d60..9917cd0d7cf 100644 --- a/tests/manual/widgets/kernel/kernel.pro +++ b/tests/manual/widgets/kernel/kernel.pro @@ -1,2 +1,2 @@ TEMPLATE = subdirs -SUBDIRS = qtooltip sizeonhide layoutreplace setscreen +SUBDIRS = qtooltip layoutreplace setscreen diff --git a/tests/manual/widgets/kernel/sizeonhide/CMakeLists.txt b/tests/manual/widgets/kernel/sizeonhide/CMakeLists.txt deleted file mode 100644 index e98c131f961..00000000000 --- a/tests/manual/widgets/kernel/sizeonhide/CMakeLists.txt +++ /dev/null @@ -1,16 +0,0 @@ -# Copyright (C) 2022 The Qt Company Ltd. -# SPDX-License-Identifier: BSD-3-Clause - -##################################################################### -## sizeonhide Binary: -##################################################################### - -qt_internal_add_manual_test(sizeonhide - GUI - SOURCES - main.cpp - LIBRARIES - Qt::CorePrivate - Qt::Gui - Qt::Widgets -) diff --git a/tests/manual/widgets/kernel/sizeonhide/main.cpp b/tests/manual/widgets/kernel/sizeonhide/main.cpp deleted file mode 100644 index a20e6d3827f..00000000000 --- a/tests/manual/widgets/kernel/sizeonhide/main.cpp +++ /dev/null @@ -1,96 +0,0 @@ -// Copyright (C) 2013 Thorbjørn Martsum - tmartsum[at]gmail.com -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only - -#include - -class KeepSizeExampleDlg : public QDialog -{ - Q_OBJECT -public: - QGridLayout *gridLayout; - QHBoxLayout *horizontalLayout; - QVBoxLayout *verticalLayout; - QCheckBox *checkBox; - QCheckBox *checkBox2; - QCheckBox *checkBox3; - QCheckBox *checkBox4; - QGroupBox *groupBox; - QVBoxLayout *verticalLayout2; - QRadioButton *radioButton; - QRadioButton *radioButton2; - QRadioButton *radioButton3; - QTableView *tableView; - QPushButton *pushButton; - QSpacerItem *horizontalSpacer; - - KeepSizeExampleDlg() - { - QWidget *form = this; - form->resize(408, 295); - gridLayout = new QGridLayout(form); - horizontalLayout = new QHBoxLayout(); - verticalLayout = new QVBoxLayout(); - checkBox = new QCheckBox(form); - verticalLayout->addWidget(checkBox); - checkBox2 = new QCheckBox(form); - verticalLayout->addWidget(checkBox2); - checkBox3 = new QCheckBox(form); - verticalLayout->addWidget(checkBox3); - checkBox4 = new QCheckBox(form); - verticalLayout->addWidget(checkBox4); - horizontalLayout->addLayout(verticalLayout); - groupBox = new QGroupBox(form); - verticalLayout2 = new QVBoxLayout(groupBox); - radioButton = new QRadioButton(groupBox); - verticalLayout2->addWidget(radioButton); - radioButton2 = new QRadioButton(groupBox); - verticalLayout2->addWidget(radioButton2); - radioButton3 = new QRadioButton(groupBox); - verticalLayout2->addWidget(radioButton3); - horizontalLayout->addWidget(groupBox); - gridLayout->addLayout(horizontalLayout, 0, 0, 1, 2); - tableView = new QTableView(form); - gridLayout->addWidget(tableView, 1, 0, 1, 2); - pushButton = new QPushButton(form); - gridLayout->addWidget(pushButton, 2, 0, 1, 1); - horizontalSpacer = new QSpacerItem(340, 20, QSizePolicy::Expanding, QSizePolicy::Minimum); - gridLayout->addItem(horizontalSpacer, 2, 1, 1, 1); - checkBox->setText(QString::fromUtf8("CheckBox1")); - checkBox2->setText(QString::fromUtf8("CheckBox2")); - checkBox3->setText(QString::fromUtf8("CheckBox - for client A only")); - checkBox4->setText(QString::fromUtf8("CheckBox - also for client A")); - groupBox->setTitle(QString::fromUtf8("Mode")); - radioButton->setText(QString::fromUtf8("Mode 1")); - radioButton2->setText(QString::fromUtf8("Mode 2")); - radioButton3->setText(QString::fromUtf8("Mode 3")); - pushButton->setText(QString::fromUtf8("&Hide/Show")); - - QObject::connect(pushButton, SIGNAL(clicked()), this, SLOT(showOrHide())); - } - - protected slots: - void showOrHide() - { - if (checkBox3->isVisible()) { - checkBox3->hide(); - checkBox4->hide(); - } else { - checkBox3->show(); - checkBox4->show(); - } - } -}; - -int main(int argc, char *argv[]) -{ - QApplication app(argc, argv); - KeepSizeExampleDlg d; - QSizePolicy policyKeepSpace = d.checkBox3->sizePolicy(); - policyKeepSpace.setRetainSizeWhenHidden(true); - d.checkBox3->setSizePolicy(policyKeepSpace); - d.checkBox4->setSizePolicy(policyKeepSpace); - d.show(); - app.exec(); -} - -#include "main.moc" diff --git a/tests/manual/widgets/kernel/sizeonhide/sizeonhide.pro b/tests/manual/widgets/kernel/sizeonhide/sizeonhide.pro deleted file mode 100644 index 1969392ab32..00000000000 --- a/tests/manual/widgets/kernel/sizeonhide/sizeonhide.pro +++ /dev/null @@ -1,3 +0,0 @@ -TEMPLATE = app -SOURCES = main.cpp -QT += widgets core-private