Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Threads not closing after converting DOM to image #98

Open
MartinTiangco opened this issue Jul 1, 2024 · 0 comments
Open

Threads not closing after converting DOM to image #98

MartinTiangco opened this issue Jul 1, 2024 · 0 comments

Comments

@MartinTiangco
Copy link

MartinTiangco commented Jul 1, 2024 •
edited
Loading

Steps To Reproduce

  1. Get dataURL from a node
  2. Firefox debugger indicates a new thread being started for each invocation of domToJpeg, which doesn't close.

Playground for https://codesandbox.io

Click the button titled "Get dataURL for title" and inspect the threads in Firefox devtools. Notice there is a new thread everytime you press on the button. This thread does not close after retrieving the dataURL.

modern-screenshot-threads-not-closing.mov

Your Environment

  • react ^17.0.2
  • react-dom ^17.0.2
  • modern-screenshot: 4.4.39
  • Browser: Firefox 127.0.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MartinTiangco