Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to render element which has display:contents; property #83

Open
nextend opened this issue Mar 11, 2024 · 0 comments
Open

Not able to render element which has display:contents; property #83

nextend opened this issue Mar 11, 2024 · 0 comments
Labels

Comments

@nextend
Copy link

nextend commented Mar 11, 2024

When the node which you want to render has display: contents; property applied, the library unable to generate screenshot as the canvas size will be 0px/0px. It is caused by that the library depends on the .getBoundingClientRect() of the given node, but display:contents element do not have size.

The problem lies in create-context.ts

function resolveBoundingBox(node: Node, context: Context) {
  let { width, height } = context

  if (isElementNode(node) && (!width || !height)) {
    const box = node.getBoundingClientRect()

    width = width
      || box.width
      || Number(node.getAttribute('width'))
      || 0

    height = height
      || box.height
      || Number(node.getAttribute('height'))
      || 0
  }

  return { width, height }
}

Here is an alternative implementation of getBoundingClientRect() which tries to fix the problems with display:contents elements.

/**
 *
 * @param element
 * @return {DOMRect}
 */
export function recursiveGetBoundingClientRect(element) {

    const cs = element.ownerDocument.defaultView.getComputedStyle(element);

    if (cs.display === 'contents') {
        /**
         *
         * @type {Node[]}
         */
        const childNodes = Array.from(element.childNodes);
        /**
         * @type DOMRect[]
         */
        const rects = childNodes.reduce((accumulator, childNode) => {
            if (childNode.nodeType === Node.ELEMENT_NODE) {

                accumulator.push(recursiveGetBoundingClientRect(childNode));
                return accumulator;
            } else if (childNode.nodeType === Node.TEXT_NODE) {
                const range = element.ownerDocument.createRange();
                range.selectNode(childNode);
                return range.getBoundingClientRect();
            }
        }, []);

        if (rects.length) {
            return mergeDOMRects(rects);
        }

        return findParentDomRect(element);
    }

    return element.getBoundingClientRect();
}

function mergeDOMRects(rects) {
    if (!rects || rects.length === 0) {
        return null;
    }

    let minX = rects[0].left;
    let minY = rects[0].top;
    let maxX = rects[0].right;
    let maxY = rects[0].bottom;

    rects.forEach(rect => {
        if (rect.left < minX) minX = rect.left;
        if (rect.top < minY) minY = rect.top;
        if (rect.right > maxX) maxX = rect.right;
        if (rect.bottom > maxY) maxY = rect.bottom;
    });

    return new DOMRect(minX, minY, maxX - minX, maxY - minY);
}

/**
 *
 * @param {Node} node
 * @return {DOMRect}
 */
function findParentDomRect(node) {

    const ownerDocument = node.ownerDocument;
    let currentElement = node.parentElement;

    while (currentElement && currentElement !== ownerDocument.documentElement) {
        if (ownerDocument.defaultView.getComputedStyle(currentElement).display !== 'contents') {
            return currentElement.getBoundingClientRect();
        }
        currentElement = currentElement.parentElement;
    }

    const window = ownerDocument.defaultView;

    return new DOMRect(0, 0, window.innerWidth, window.innerHeight);
}
@qq15725 qq15725 added the Feature label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants