Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build of version 0.9.5 #298

Closed
archeoss opened this issue Nov 4, 2023 · 0 comments · Fixed by #299
Closed

Fix build of version 0.9.5 #298

archeoss opened this issue Nov 4, 2023 · 0 comments · Fixed by #299
Assignees
Labels
bug Something isn't working

Comments

@archeoss
Copy link
Contributor

archeoss commented Nov 4, 2023

Duplicate of bob-tools/#86

aHash version that we used was yanked. This breaks the build. As a solution we can copy the source code of a particular version of aHash into Pearl.

The following steps should be done:

  1. New release branch should be created (release_v0.9.6) from branch release_v0.9.5 (https://github.com/qoollo/pearl/tree/release_v0.9.5)
  2. Branch for this issue should be created from branch release_v0.9.6 and the following Pull Request should target release_v0.9.6
  3. aHash of version 0.7.4 should be copied (commit ffa04fcb81f39755f636c75c9b7aa06533c0ae75) to src/filter/aHash/ directory
  4. Include copyright notice and particular version in the comment on the top of every copied file
  5. Update the code to use the copied version of aHash
  6. Verify that the calculated hash matches the ones that was calculated by the original version (this test should pass: https://github.com/qoollo/pearl/blob/release_v0.9.5/tests/tests.rs#L24)
  7. Verify that there is no observable performance degradation (by running pearl benchmarks)

Comment on the top of every file can look like this:

// Original work: Copyright (c) 2018 Tom Kaitchuck
// Distributed under MIT license
// Taken from aHash version 0.7.4 (commit ffa04fcb81f39755f636c75c9b7aa06533c0ae75)
@archeoss archeoss added the bug Something isn't working label Nov 4, 2023
@archeoss archeoss self-assigned this Nov 4, 2023
@archeoss archeoss linked a pull request Nov 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant