Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove raw fork from tests and use rusty-fork instead #254

Closed
ikopylov opened this issue Mar 17, 2023 · 0 comments · Fixed by #255
Closed

Remove raw fork from tests and use rusty-fork instead #254

ikopylov opened this issue Mar 17, 2023 · 0 comments · Fixed by #255
Assignees
@idruzhitskiy
Labels
bug Something isn't working

Comments

@ikopylov
Copy link
Member

https://github.com/qoollo/pearl/blob/v0.18.0/tests/tests.rs#L239

fork withing the tests is incorrect, since the test engine is also forked. We should use a different approach. For example, the crate rusty-fork (https://crates.io/crates/rusty-fork) runs the same test with additional parameters. It's worth to use it
@ikopylov ikopylov added the bug Something isn't working label Mar 17, 2023
@ikopylov ikopylov mentioned this issue Mar 17, 2023
Merged
@idruzhitskiy idruzhitskiy mentioned this issue Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idruzhitskiy idruzhitskiy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

254-better-fork qoollo/pearl
2 participants
@ikopylov @idruzhitskiy