Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate the possibility of returning an error instead of a panic when file is locked by another process #253

Open
ikopylov opened this issue Mar 17, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ikopylov
Copy link
Member

https://github.com/qoollo/pearl/blob/v0.18.0/src/blob/file.rs#L49

When an advisory lock cannot be acquired, the process panics. In general, in such cases it is better to return an error. But this can lead to the skipping of some files, which is incorrect. Normally, the error should propagate to the storage level and prevent it from being created/started. The possibility of such changes should be investigated

@ikopylov ikopylov added the enhancement New feature or request label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant