Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The key is converted to a vector and back to a key two times in IndexStruct::push #193

Closed
ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #203
Closed

The key is converted to a vector and back to a key two times in IndexStruct::push #193

ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #203
Assignees
@lostl1ght
Labels
enhancement New feature or request performance

Comments

@ikopylov
Copy link
Member

First strange conversion: https://github.com/qoollo/pearl/blob/master/src/blob/index/core.rs#L268
Second: https://github.com/qoollo/pearl/blob/master/src/blob/index/core.rs#L275

Looks like h.key() can be used directly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lostl1ght lostl1ght

Labels
enhancement New feature or request performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

193 fix excessive conversion and add impls where needed qoollo/pearl
2 participants
@ikopylov @lostl1ght