We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record
Currently, the whole data copied to the final vector here: https://github.com/qoollo/pearl/blob/master/src/record.rs#L116 This becomes a problem, when data is large (~1Gb). We can try to avoid this copy and pass data as a separate parameter to write_append here: https://github.com/qoollo/pearl/blob/master/src/blob/core.rs#L240
write_append
There is write_all_vectored function (https://doc.rust-lang.org/std/io/trait.Write.html#method.write_all_vectored) to write 2 buffers in a single call, but it is nightly. Still not copying should provide a significant improvement for large data even with two write calls.
write_all_vectored
If the data is small (<4Kb) we can use the current approach with single buffer. For large data 2 calls is better
The text was updated successfully, but these errors were encountered:
Related to #189
Sorry, something went wrong.
Pearl
idruzhitskiy
Successfully merging a pull request may close this issue.
Currently, the whole data copied to the final vector here: https://github.com/qoollo/pearl/blob/master/src/record.rs#L116
This becomes a problem, when data is large (~1Gb).
We can try to avoid this copy and pass data as a separate parameter to
write_append
here: https://github.com/qoollo/pearl/blob/master/src/blob/core.rs#L240There is
write_all_vectored
function (https://doc.rust-lang.org/std/io/trait.Write.html#method.write_all_vectored) to write 2 buffers in a single call, but it is nightly. Still not copying should provide a significant improvement for large data even with two write calls.If the data is small (<4Kb) we can use the current approach with single buffer. For large data 2 calls is better
The text was updated successfully, but these errors were encountered: