We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storage
Too many unnecessary pub(crate) usage (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs). Looks like ioring should be totally private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L55) config and safe can have readonly access, so they should be exposed through the getter and declared as private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L52). Same for fields of Safe: they should not be available for updated outside (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L63). From the architecture point of view, Safe should not visible at all, because it is an integral part of Inner<K> protected by lock (this is discussable).
pub(crate)
ioring
config
safe
Safe
Inner<K>
The text was updated successfully, but these errors were encountered:
Pearl::Storage
ikopylov
Successfully merging a pull request may close this issue.
Too many unnecessary
pub(crate)
usage (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs).Looks like
ioring
should be totally private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L55)config
andsafe
can have readonly access, so they should be exposed through the getter and declared as private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L52).Same for fields of
Safe
: they should not be available for updated outside (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L63). From the architecture point of view,Safe
should not visible at all, because it is an integral part ofInner<K>
protected by lock (this is discussable).The text was updated successfully, but these errors were encountered: