Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update visibility levels in Storage #186

Closed
ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #265
Closed

Review and update visibility levels in Storage #186

ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request

Comments

@ikopylov
Copy link
Member

Too many unnecessary pub(crate) usage (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs).
Looks like ioring should be totally private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L55)
config and safe can have readonly access, so they should be exposed through the getter and declared as private (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L52).
Same for fields of Safe: they should not be available for updated outside (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L63). From the architecture point of view, Safe should not visible at all, because it is an integral part of Inner<K> protected by lock (this is discussable).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant