Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and update Arc placement in Storage #185

Closed
ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #265
Closed

Review and update Arc placement in Storage #185

ikopylov opened this issue Aug 31, 2022 · 0 comments · Fixed by #265
Assignees
Labels
enhancement New feature or request

Comments

@ikopylov
Copy link
Member

Looks like only inner should be wrapped in Arc (https://github.com/qoollo/pearl/blob/master/src/storage/core.rs#L43), because it is actually passed outside. All inner fields like safe, next_blob_id, blobs does not pass outside (from the first glance), so it looks like Arc on them can be safely removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant