Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit logging usage #6

Open
Battlesquid opened this issue Jul 26, 2024 · 0 comments
Open

Revisit logging usage #6

Battlesquid opened this issue Jul 26, 2024 · 0 comments

Comments

@Battlesquid
Copy link
Member

Currently, the logger usage is fairly inconsistent, specifically in terms of labels. There are several instances of functions that are deeper in the execution chain setting a label on the logger. This is counterintuitive because we lose the actual context from where the log stems from. The logging should be redone to only set labels at top level functions and use another key/method for identifying lower level functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant