Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support docker build in qmk_userspace repos #24

Closed
sotte opened this issue Jun 22, 2024 · 1 comment · Fixed by qmk/qmk_firmware#23988
Closed

[Feature Request] Support docker build in qmk_userspace repos #24

sotte opened this issue Jun 22, 2024 · 1 comment · Fixed by qmk/qmk_firmware#23988
Labels
enhancement New feature or request

Comments

@sotte
Copy link

sotte commented Jun 22, 2024

Description

The main qmk firmware repository provides the handy "build via docker" features.
Here are the docs: https://docs.qmk.fm/getting_started_docker
Here is the implementation: https://github.com/qmk/qmk_firmware/blob/master/util/docker_build.sh

It would be great if qmk_userspace also supported ''build via docker".

(The github actions basically do something along the lines, but you cannot easily reproduce it locally.)

Potential implementation:

  • download the qmk_firmware repo within the docker container
  • point to a local qmk_firmware checkout
@sotte
Copy link
Author

sotte commented Jun 24, 2024

Thanks a lot @tzarc. Works like a charm.

I'm wondering if we should mention the userspace build in the "getting started with docker" documentation here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant