Add support for KBDPAD MKII #6034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
reviewed
May 31, 2019
| * represents the switch matrix. | ||
| */ | ||
| #define LAYOUT( \ | ||
| K00, K01, K02, K03, \ |
There was a problem hiding this comment.
curious why you decided to go Kxy here and for the kbd8x mkii you went with Kxyz.
There was a problem hiding this comment.
Looking back at it, I have no idea. Probably either extreme fatigue, or too long of a gap between the pad and 8x's revised PCB that I forgot how I labeled it on the 8x.
e11i0t23
reviewed
May 31, 2019
drashna
reviewed
May 31, 2019
Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]>
drashna
requested changes
Jun 1, 2019
Co-Authored-By: Drashna Jaelre <[email protected]>
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Build some testing keymaps * Match naming convention to 8x * Add configurator json * Forgot to build the readme * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/kbdfans/kbdpad_mk2/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]>
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Build some testing keymaps * Match naming convention to 8x * Add configurator json * Forgot to build the readme * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/kbdfans/kbdpad_mk2/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]>
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
* Build some testing keymaps * Match naming convention to 8x * Add configurator json * Forgot to build the readme * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/kbdfans/kbdpad_mk2/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]>
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* Build some testing keymaps * Match naming convention to 8x * Add configurator json * Forgot to build the readme * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/kbdfans/kbdpad_mk2/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the KBDPAD MKII numpad.
Types of Changes
Issues Fixed or Closed by This PR
Checklist