Add support for KBD8X MKII #6033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mechmerlin
requested changes
May 31, 2019
|
|
||
|  | ||
|
|
||
| A fairly typical TKL |
There was a problem hiding this comment.
also, it doesn't quite match the tkl_ansi layout we have. :(
| # if this doesn't work, see here: https://github.com/tmk/tmk_keyboard/wiki/FAQ#nkro-doesnt-work | ||
| NKRO_ENABLE = yes # USB Nkey Rollover | ||
| BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality on B7 by default | ||
| RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow |
There was a problem hiding this comment.
I see that you have pins defined for this and setting this enabled makes total sense. However, the board itself doesn't seem to have any translucent areas that would make use of this underglow. Please correct me if I'm wrong. Nothing to really change here, just me curious.
There was a problem hiding this comment.
The PCB has built-in RGB underglow LEDs, which take advantage of the option of polycarbonate bottoms.
For aluminum-bottomed builds, it will be useless.
e11i0t23
reviewed
May 31, 2019
Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: MechMerlin <[email protected]>
drashna
approved these changes
Jun 1, 2019
|
Thanks! |
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
* Begin work * Make things a tad easier to read * Fix spacing * Get things compiling * Build a variety of generic keymaps * Correct RGB pin * Add configurator json * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: MechMerlin <[email protected]>
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
* Begin work * Make things a tad easier to read * Fix spacing * Get things compiling * Build a variety of generic keymaps * Correct RGB pin * Add configurator json * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: MechMerlin <[email protected]>
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
* Begin work * Make things a tad easier to read * Fix spacing * Get things compiling * Build a variety of generic keymaps * Correct RGB pin * Add configurator json * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: MechMerlin <[email protected]>
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
* Begin work * Make things a tad easier to read * Fix spacing * Get things compiling * Build a variety of generic keymaps * Correct RGB pin * Add configurator json * Apply suggestions from code review Co-Authored-By: Elliot Powell <[email protected]> Co-Authored-By: MechMerlin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the KBD8X MKII keyboard.
Types of Changes
Issues Fixed or Closed by This PR
Checklist