Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LED Matrix: replace backlight keycodes with newly added ones #23455

Merged
merged 3 commits into from
Apr 13, 2024
Merged

LED Matrix: replace backlight keycodes with newly added ones #23455

merged 3 commits into from
Apr 13, 2024

Conversation

fauxpark
Copy link
Member

Description

#23426, the final part. LED Matrix is now controlled by the LM_ keycodes added in #23432.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 11, 2024
@fauxpark fauxpark requested a review from a team April 11, 2024 04:19
@zvecr zvecr merged commit bbf63a8 into qmk:develop Apr 13, 2024
5 checks passed
@fauxpark fauxpark deleted the led-matrix-keycodes-update branch April 13, 2024 03:22
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@fauxpark @whoisjordangarcia
LED Matrix: replace backlight keycodes with newly added ones (qmk#23455)
da6e9c2
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED Matrix: replace backlight keycodes with newly added ones (qmk#23455)
91d3192
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@fauxpark @Ardakilic
LED Matrix: replace backlight keycodes with newly added ones (qmk#23455)
d37504d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @zvecr @noroadsleft