Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new set of keycodes for LED Matrix #23432

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Apr 7, 2024

Description

Part 2 of #23426. This adds the new keycodes but they don't do anything yet; process_led_matrix() added in the previous PR needs to be updated to replace the backlight keycodes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team April 7, 2024 01:52
@noroadsleft noroadsleft requested a review from a team April 9, 2024 07:26
@fauxpark fauxpark merged commit 52d3ef0 into qmk:develop Apr 11, 2024
5 checks passed
@fauxpark fauxpark deleted the led-matrix-keycodes branch April 11, 2024 04:14
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants