Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align encoder layout validation with encoder.h logic #23330

Merged
merged 1 commit into from
Mar 31, 2024
Merged

Align encoder layout validation with encoder.h logic #23330

merged 1 commit into from
Mar 31, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 22, 2024 •
edited
Loading

Description

Was not taking into account the case https://github.com/qmk/qmk_firmware/blob/develop/quantum/encoder.h#L51, where right encoders will default to left if not configured. This would produce the following error

☒ zvecr/zv48/f401: Layout "LAYOUT_ortho_4x12" contains out of bounds encoder index 1.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Mar 22, 2024
@github-actions github-actions bot added keyboard python cli qmk cli command labels Mar 22, 2024
@dunk2k
Copy link
Contributor

dunk2k commented Mar 22, 2024

@zvecr
Would it be possible to base this to master?

@zvecr zvecr merged commit ea71945 into develop Mar 31, 2024
6 checks passed
@zvecr zvecr deleted the fix_split_encoder_oob branch March 31, 2024 20:39
@dunk2k dunk2k mentioned this pull request Apr 1, 2024
Merged
13 tasks
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
Align encoder layout validation with encoder.h logic (qmk#23330)
1132f05
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Align encoder layout validation with encoder.h logic (qmk#23330)
6f89da5
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
Align encoder layout validation with encoder.h logic (qmk#23330)
272027f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
bug cli qmk cli command keyboard python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @dunk2k @drashna