Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privileged flag to runtime command #18932

Closed
wants to merge 1 commit into from

Conversation

Siilwyn
Copy link

@Siilwyn Siilwyn commented Nov 1, 2022

Description

Seems like this flag is always needed?

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 1, 2022
@Siilwyn Siilwyn changed the base branch from master to develop November 1, 2022 19:49
@Siilwyn Siilwyn changed the base branch from develop to master November 1, 2022 19:49
@tzarc
Copy link
Member

tzarc commented Nov 1, 2022

You’ll have to explain why you think it’s needed — works fine for me without it.

@Siilwyn
Copy link
Author

Siilwyn commented Nov 1, 2022

@tzarc maybe you're using a different OS?
What more info would you like to see besides what's described in #18130?

@tzarc
Copy link
Member

tzarc commented Nov 1, 2022

Have replied on the issue, can't reproduce it locally.

@zvecr
Copy link
Member

zvecr commented Nov 11, 2022

Closing as the current implementation isnt the solution we would want, further discussion can continue in the linked issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants