From 989231bc13c65e93425022ae594c73395f23ace5 Mon Sep 17 00:00:00 2001 From: Minke Zhang Date: Sun, 1 May 2022 01:10:52 -0700 Subject: [PATCH 1/4] Update YMDK Split 64 config with correct indicator LED pins --- keyboards/ymdk/sp64/config.h | 10 ++++++++++ keyboards/ymdk/sp64/rules.mk | 8 ++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/keyboards/ymdk/sp64/config.h b/keyboards/ymdk/sp64/config.h index 38880d1a850e..be0edc18f208 100644 --- a/keyboards/ymdk/sp64/config.h +++ b/keyboards/ymdk/sp64/config.h @@ -30,6 +30,16 @@ along with this program. If not, see . #define RIGHT_HALF +/* LED indicator lights + * + * Based off of the ps2avrGB pearl (/keyboards/pearl) and manually verified. + * + * See https://github.com/qmk/qmk_firmware/issues/9123#issuecomment-630235214. + */ +#define LED_CAPS_LOCK_PIN D1 +#define LED_NUM_LOCK_PIN D0 +#define LED_SCROLL_LOCK_PIN D6 + /* RGB underglow */ #define RGBLED_NUM 12 #define RGBLIGHT_HUE_STEP 8 diff --git a/keyboards/ymdk/sp64/rules.mk b/keyboards/ymdk/sp64/rules.mk index 7d52d7ca7873..c7b954568661 100644 --- a/keyboards/ymdk/sp64/rules.mk +++ b/keyboards/ymdk/sp64/rules.mk @@ -10,16 +10,16 @@ BOOTLOADER = bootloadhid BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite MOUSEKEY_ENABLE = no # Mouse keys EXTRAKEY_ENABLE = yes # Audio control and System control -CONSOLE_ENABLE = no # Console for debug +CONSOLE_ENABLE = no # Console for debug COMMAND_ENABLE = yes # Commands for debug and configuration NKRO_ENABLE = no # Enable N-Key Rollover -#BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality -AUDIO_ENABLE = no # There is no speaker on this PCB +# BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality +AUDIO_ENABLE = no # There is no speaker on this PCB RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow CUSTOM_MATRIX = yes # Needed for underglow WS2812_DRIVER = i2c -SRC += matrix.c +SRC += matrix.c QUANTUM_LIB_SRC += i2c_master.c From a3dcf7fff2bb513b442ae43983553c9bc2d28e63 Mon Sep 17 00:00:00 2001 From: Minke Zhang Date: Mon, 2 May 2022 11:06:12 -0700 Subject: [PATCH 2/4] Update keyboards/ymdk/sp64/config.h Co-authored-by: Joel Challis --- keyboards/ymdk/sp64/config.h | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/keyboards/ymdk/sp64/config.h b/keyboards/ymdk/sp64/config.h index be0edc18f208..f7b34575af32 100644 --- a/keyboards/ymdk/sp64/config.h +++ b/keyboards/ymdk/sp64/config.h @@ -30,12 +30,7 @@ along with this program. If not, see . #define RIGHT_HALF -/* LED indicator lights - * - * Based off of the ps2avrGB pearl (/keyboards/pearl) and manually verified. - * - * See https://github.com/qmk/qmk_firmware/issues/9123#issuecomment-630235214. - */ +/* LED indicator lights */ #define LED_CAPS_LOCK_PIN D1 #define LED_NUM_LOCK_PIN D0 #define LED_SCROLL_LOCK_PIN D6 From 2014a5e8d70682354d2b4a43d9b9165d0c413b24 Mon Sep 17 00:00:00 2001 From: Minke Zhang Date: Mon, 2 May 2022 22:44:31 -0700 Subject: [PATCH 3/4] Update keyboards/ymdk/sp64/rules.mk Co-authored-by: Ryan --- keyboards/ymdk/sp64/rules.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/keyboards/ymdk/sp64/rules.mk b/keyboards/ymdk/sp64/rules.mk index c7b954568661..e818f8114c54 100644 --- a/keyboards/ymdk/sp64/rules.mk +++ b/keyboards/ymdk/sp64/rules.mk @@ -13,7 +13,7 @@ EXTRAKEY_ENABLE = yes # Audio control and System control CONSOLE_ENABLE = no # Console for debug COMMAND_ENABLE = yes # Commands for debug and configuration NKRO_ENABLE = no # Enable N-Key Rollover -# BACKLIGHT_ENABLE = yes # Enable keyboard backlight functionality +BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality AUDIO_ENABLE = no # There is no speaker on this PCB RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow CUSTOM_MATRIX = yes From 65bb0c68392148f52275d56dfc8db53ce3370de8 Mon Sep 17 00:00:00 2001 From: Minke Zhang Date: Mon, 2 May 2022 23:56:37 -0700 Subject: [PATCH 4/4] Update keyboards/ymdk/sp64/rules.mk --- keyboards/ymdk/sp64/rules.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/keyboards/ymdk/sp64/rules.mk b/keyboards/ymdk/sp64/rules.mk index e818f8114c54..3dfe95cc0f47 100644 --- a/keyboards/ymdk/sp64/rules.mk +++ b/keyboards/ymdk/sp64/rules.mk @@ -14,7 +14,8 @@ CONSOLE_ENABLE = no # Console for debug COMMAND_ENABLE = yes # Commands for debug and configuration NKRO_ENABLE = no # Enable N-Key Rollover BACKLIGHT_ENABLE = no # Enable keyboard backlight functionality -AUDIO_ENABLE = no # There is no speaker on this PCB +AUDIO_ENABLE = no # Audio output +AUDIO_SUPPORTED = no RGBLIGHT_ENABLE = yes # Enable keyboard RGB underglow CUSTOM_MATRIX = yes