Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Caps Word: Auto-press shift momentarily for each letter, instead of all the time #21568

Closed
1 of 4 tasks
mellanslag-de opened this issue Jul 20, 2023 · 5 comments
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.

Comments

@mellanslag-de
Copy link

Feature Request Type

  • Core functionality
  • Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
  • Alteration (enhancement/optimization) of existing feature(s)
  • New behavior

Description

Currently, when I enable Caps Word and type at least one letter, shift is held down for 5 seconds (until timeout).

When I e.g. click around in my IDE in that time frame, text fragments get selected (between old cursor position and new cursor position), because shift is held down.

I want to propose to not keep shift pressed the whole time, but instead momentarily enable it for each key press while caps word is on, and immediately after sending the pressed key, releasing shift again.

That way, if I click around, no unwanted behaviour is caused.


Was that already considered? Any implications I currently dont see? Or can we make it configurable?

@mellanslag-de
Copy link
Author

The original Issue where the feature was implemented: #16588

@getreuer
Copy link
Contributor

That's an interesting idea!

It's not what you asked for, but it might help that Caps Word's 5-second timeout can be configured (documentation). Tighten it to, say, 3 seconds by adding in config.h:

#define CAPS_WORD_IDLE_TIMEOUT 3000  // 3 seconds.

@casuanoob
Copy link
Contributor

I can only replicate this if I keep holding down the letter key while clicking.

Looking at process_caps_word.c it seems like caps word has always been implemented by using add_weak_mods to add weak shift to the subsequent keypress.
So for the host device shift should only appear to be held down for as long as each letter key is held.

So what I mean is - caps word is already implemented as a momentary press of shift with each keypress.

Copy link

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 28, 2023
Copy link

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.
// [stale-action-closed]

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted stale Issues or pull requests that have become inactive without resolution.
Projects
None yet
Development

No branches or pull requests

3 participants