[Feature Request] Use the Global Brightness Parameter of the APA102 LEDs

[tyalie]

The APA102 are supported by qmk, but the implementation misses one important feature:

The global brightness flag is always set to full brightness. Compare the package description from here with the code in qmk:

qmk_firmware/drivers/avr/apa102.c

Line 42 in e4823aa

apa102_send_frame(0xFF000000 | (data->b << 16) | (data->g << 8) | data->r);

Making use of the global brightness flag, by using the RGBLIGHT_LIMIT_VAL (and similar for RGB MATRIX) in this line would allow 256 colors even at low brightness. A scenario that seems more likely than using the full brightness all the time.

I write this feature request only for documentation and to draw awareness to the problem. I've no keyboard with APA102 leds to test it (even though my next keyboard will definitely have them). I might be overlooking some limitation here.

Feature Request Type

• Core functionality
• Add-on hardware support (eg. audio, RGB, OLED screen, etc.)
• Alteration (enhancement/optimization) of existing feature(s)
• New behavior

[stale]

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 30 days unless it is tagged properly or other activity occurs.
For maintainers: Please label with bug, in progress, on hold, discussion or to do to prevent the issue from being re-flagged.

[stale]

This issue has been automatically closed because it has not had activity in the last 30 days. If this issue is still valid, re-open the issue and let us know.