From 1b407f3da812125c5542532c336dcd428d2ba5d3 Mon Sep 17 00:00:00 2001 From: ThePurox <28731015+ThePurox@users.noreply.github.com> Date: Tue, 11 Apr 2023 08:03:00 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Joel Challis --- keyboards/hackpad/hackpad.c | 2 -- keyboards/hackpad/info.json | 8 ++------ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/keyboards/hackpad/hackpad.c b/keyboards/hackpad/hackpad.c index 8cd905aaf81d..3d729c1f0e12 100644 --- a/keyboards/hackpad/hackpad.c +++ b/keyboards/hackpad/hackpad.c @@ -1,8 +1,6 @@ // Copyright 2023 Nico Stuhlmueller (@ThePurox) // SPDX-License-Identifier: GPL-2.0-or-later -#include QMK_KEYBOARD_H - bool encoder_update_kb(uint8_t index, bool clockwise) { if (clockwise) { tap_code_delay(KC_VOLU, 10); diff --git a/keyboards/hackpad/info.json b/keyboards/hackpad/info.json index 47b673463ae0..83ec819f032e 100644 --- a/keyboards/hackpad/info.json +++ b/keyboards/hackpad/info.json @@ -5,11 +5,11 @@ "development_board": "promicro", "diode_direction": "COL2ROW", "features": { - "bootmagic": false, + "bootmagic": true, "command": false, "console": false, "extrakey": true, - "mousekey": false, + "mousekey": true, "nkro": true, "rgblight": true, "encoder" : true @@ -34,10 +34,6 @@ }, "rgblight" : { "led_count" : 16, - "hue_steps" : 20, - "brightness_steps" : 10, - "saturation_steps" : 20, - "max_brightness" : 255, "sleep" : true, "animations": { "breathing" : true,