Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update readme and storybook #58

Merged
merged 4 commits into from
May 26, 2022
Merged

Conversation

devonpis
Copy link
Contributor

  • update readme
  • re-organise storybook doc pages
  • add how to page
  • add why and when page

@devonpis devonpis requested a review from a team May 25, 2022 02:36
Copy link
Member

@duttonw duttonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good, may i suggest you include the 'exports' of the form and the resource in your WhyAndWhen story for others who don't have access to that project (or in the case the project example drift)

@@ -157,6 +157,16 @@ We will use **Grab my IP** solution as an example.
>
This link is a real live solution using this approach.
</a>
<br />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to complete this example, can you make this into a custom component as its 'everywhere'

@devonpis devonpis merged commit ae80f10 into main May 26, 2022
@duttonw duttonw deleted the update-readme-and-storybook-doc-content branch November 20, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants