set projectURl and baseUrl on pre-request #56
Conversation
| @@ -15,6 +15,8 @@ const requestPluginHandler = (requestArgs, opts) => { | |||
| requestArgs.opts.base = requestArgs.formio.options.base; | |||
| requestArgs.opts.project = requestArgs.formio.options.project; | |||
| requestArgs.opts.namespace = requestArgs.formio.options.namespace; | |||
| Formio.setProjectUrl(requestArgs.formio.options.project); | |||
There was a problem hiding this comment.
hmm global, that is strange. how many of these 'gotchas' have we come accross.
There was a problem hiding this comment.
this actual did fix in few places, as in formio.js, there are few ocassions using Formio.getProjectUrl to contruct URL for internal request, such as PDF, nested Form, Select (using data resource). (not every component using this method to construct URL tho, eg. ReCaptcha)
by adding Formio.setProjectUrl in pre-request hook, hence update the global Formio just before the request, luckily we still can support multiple forms with this patch.
There was a problem hiding this comment.
Thanks for doing the discovery, could you raise and issue on the formio js upstream project with examples where they missed local variable instead of global with the proviso to doing multi form on one page with different 'stages/projects'
this will fix the URL construction of data resource request from a select doesn't contain the projectId
eg.
before:
api.forms.platforms.qld.gov.au/form/627dd82559d38c6f610de8c7/submission?limit=10000&skip=0&data.label__regex=s&sort=data.submissionOrderBy
after:
api.forms.platforms.qld.gov.au/dev-zmuchxwdmdytntr/form/627dd82559d38c6f610de8c7/submission?limit=10000&skip=0&sort=data.submissionOrderBy