Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOLDEV-661 QOLDEV-662 QOLDEV-663 Data grid improvement #253

Merged
merged 3 commits into from
Nov 19, 2023

Conversation

ghazal-salehi
Copy link
Contributor

@ghazal-salehi ghazal-salehi commented Nov 9, 2023

  • Removing border style as it should inherit from SWE.
  • Applying w-100 to table cells to fix the width issue.
  • Setting dropdown height to be consistent with the text input fields
  • Unsetting right padding that was breaking the dropdown style

Examples:
https://uat.forgov.qld.gov.au/sandbox/formio/form.io-test/employment-policy-career-and-wellbeing/flexible-work-agreement
https://oss-uat.clients.squiz.net/law/assets/forms/formio-test/vaq/apply-for-financial-assistance

Before:
image
image
image

After:
image
image
image

@ghazal-salehi ghazal-salehi self-assigned this Nov 9, 2023
@ghazal-salehi ghazal-salehi changed the title QOLDEV-661 QOLDEV-661 Data grid improvement QOLDEV-661 QOLDEV-663 Data grid improvement Nov 9, 2023
@ghazal-salehi
Copy link
Contributor Author

I need to move these changes to src/sass. On hold for now.

@duttonw
Copy link
Member

duttonw commented Nov 9, 2023

@ghazal-salehi , yes do add to https://github.com/qld-gov-au/formio/blob/main/src/sass/formio.form.swe.scss or another file that is included. this will be added to override the formio css.

@duttonw
Copy link
Member

duttonw commented Nov 9, 2023

please only cut v2.x.x tag's as this will increment the cdn repo and provide a build in bitbucket to allow deployment to our cdn.

@ghazal-salehi ghazal-salehi changed the title QOLDEV-661 QOLDEV-663 Data grid improvement QOLDEV-661 QOLDEV-662 QOLDEV-663 Data grid improvement Nov 10, 2023
@ThrawnCA ThrawnCA merged commit ce22df5 into develop Nov 19, 2023
4 checks passed
@duttonw duttonw deleted the QOLDEV-661-datagrid-improvement branch April 5, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants