-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HexagonalLattice
Class
#1027
Conversation
qiskit_nature/second_q/hamiltonians/lattices/hexagonal_lattice.py
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 4053980683
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides these comments, please also add a release note to this PR
qiskit_nature/second_q/hamiltonians/lattices/hexagonal_lattice.py
Outdated
Show resolved
Hide resolved
Do we want to include this in the Lattice Models tutorial - since that tutorial shows the existing models it seems to me it would be good to include this there too. |
Yesterday I found out that @mtreinish is rustworkx open to supporting similar functionality? At least periodic boundary conditions would seem useful to me. If yes, I suggest we could track the addition of similar functionality there. Since I moved this PR to 0.7.0 we could even postpone until that is available. @javabster wold you be interested in contributing this to rustworkx, assuming they want it 😄 |
Co-authored-by: Max Rossmannek <[email protected]>
Yeah, both of those seem totally valid to add to rustworkx. If you don't mind can you open an enhancement issue: with the details and we can target it for the 0.13.0 release (which we don't have a target date for yet). @javabster it'd be great if you're interested in contributing the functionality to rustworkx too. I can give you a hand if you need any help getting started on it. |
issue opened: Qiskit/rustworkx#803 |
For various bandwidth reasons I would like to restrict the scope of this PR as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's also get this one merged. I added a comment here to keep track of possible future extensions.
I also added a simple release note in a similar style to the one of the recently merged Kagome lattice.
Thank you, Abby, for contributing to Qiskit Nature and being so patient with this lengthy (and sometimes stalled) review process!
Summary
fixes #956
Details and comments