Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a HexagonalLattice #956

Closed
mrossinek opened this issue Nov 14, 2022 · 2 comments · Fixed by #1027
Closed

Add a HexagonalLattice #956

mrossinek opened this issue Nov 14, 2022 · 2 comments · Fixed by #1027
Assignees
Labels
type: feature request New feature or request
Milestone

Comments

@mrossinek
Copy link
Member

What should we add?

A new lattice should be added to the qiskit_nature.second_q.hamiltonians.lattices module, allowing the simple construction of hexagonal lattices.

Based on this class, we could then also add support for the quick construction of heavy-hex lattices which would be of great use for simulations on IBM Quantum devices.
I am open to discuss whether we want a HeavyHexLattice subclass of the HexagonalLattice or whether we want to a heavy: bool = True keyword argument for the lattice class proposed by this feature request.

(This suggestion was extracted from #43)

@mrossinek mrossinek added the type: feature request New feature or request label Nov 14, 2022
@mrossinek mrossinek added this to the 0.6.0 milestone Nov 14, 2022
@javabster
Copy link
Contributor

You can assign this to me 😄

@mrossinek
Copy link
Member Author

Although I have marked #1027 as closing this issue, we will leave the following additions for future extension. As of now, these are not planned but may be picked up by anyone who would like to. Once they do, they should open an issue for the specific feature to be added.

  • support for periodic boundary conditions
  • generation of heavy-hex lattices

@mergify mergify bot closed this as completed in #1027 Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants