Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AdaptVQE to leverage opflow gradients #123

Closed
mrossinek opened this issue Apr 12, 2021 · 1 comment · Fixed by #445
Closed

Refactor AdaptVQE to leverage opflow gradients #123

mrossinek opened this issue Apr 12, 2021 · 1 comment · Fixed by #445
Assignees
@mrossinek @dlasecki @fs1132429
Labels
short project A task amounting to a small project (but larger than a "good first issue") type: enhancement

Comments

@mrossinek
Copy link
Member

mrossinek commented Apr 12, 2021 •
edited
Loading

What is the expected enhancement?

The adaptive VQE was originally implemented in Qiskit Aqua as the outcome of the Qiskit Hackathon Europe 2019, link. Since then, it has already been refactored multiple times during the migration to the GroundStateEigensolver interface and later transition to Qiskit Nature.

As it stands today, it still performs the gradient computation manually, see here, instead of leveraging Qiskit Terra's gradient functionality released as part of Terra 0.17.0

The goal of this issue, is to refactor the implementation of AdaptVQE to make use of the native gradient functionality included in Qiskit Terra.
@mrossinek mrossinek mentioned this issue Aug 11, 2021
Open
@mrossinek mrossinek added the short project A task amounting to a small project (but larger than a "good first issue") label Aug 11, 2021
@fs1132429
Copy link
Contributor

👍

@mrossinek mrossinek mentioned this issue Nov 10, 2021
Closed
@fs1132429 fs1132429 mentioned this issue Dec 1, 2021
Merged
@mrossinek mrossinek linked a pull request Dec 1, 2021 that will close this issue
Gradient based AdaptVQE #445
Merged
@mergify mergify bot closed this as completed in #445 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrossinek mrossinek

@dlasecki dlasecki

@fs1132429 fs1132429

Labels
short project A task amounting to a small project (but larger than a "good first issue") type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gradient based AdaptVQE fs1132429/qiskit-nature
3 participants
@mrossinek @dlasecki @fs1132429