Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qutrit classifier #543

Merged
merged 15 commits into from
Oct 25, 2023
Merged

Qutrit classifier #543

merged 15 commits into from
Oct 25, 2023

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Oct 3, 2023

As the title says

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #543 (1699c01) into main (6d00390) will increase coverage by 0.01%.
Report is 2 commits behind head on main.
The diff coverage is 98.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #543      +/-   ##
==========================================
+ Coverage   96.02%   96.04%   +0.01%     
==========================================
  Files          90       92       +2     
  Lines        6062     6163     +101     
==========================================
+ Hits         5821     5919      +98     
- Misses        241      244       +3     
Flag Coverage Δ
unittests 96.04% <98.92%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/fitting/classifier/data.py 100.00% <100.00%> (ø)
src/qibocal/fitting/classifier/decision_tree.py 100.00% <100.00%> (ø)
src/qibocal/fitting/classifier/run.py 96.69% <ø> (ø)
src/qibocal/fitting/classifier/scikit_utils.py 83.33% <100.00%> (ø)
src/qibocal/protocols/characterization/__init__.py 100.00% <100.00%> (ø)
...bocal/protocols/characterization/classification.py 99.46% <100.00%> (-0.54%) ⬇️
src/qibocal/protocols/characterization/utils.py 97.23% <100.00%> (+0.76%) ⬆️
src/qibocal/update.py 95.55% <ø> (-0.10%) ⬇️
...rotocols/characterization/qutrit_classification.py 97.59% <97.59%> (ø)

@andrea-pasquale
Copy link
Contributor

andrea-pasquale commented Oct 19, 2023

@Edoardo-Pedicillo now that I've managed to calibrate the RX12 pulse for qubit 1 and 4 of qw5q_gold (qiboteam/qibolab_platforms_qrc#65) you should be able to run this on hardware.

Base automatically changed from w12_protocol to main October 23, 2023 07:42
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo for implementing this.
You can find below some comments.
I will test on hardware later and I will approve.

src/qibocal/update.py Outdated Show resolved Hide resolved
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Edoardo-Pedicillo, LGTM.

@andrea-pasquale andrea-pasquale added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit 1846495 Oct 25, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the qutrit_classifier branch October 25, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants