-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protocol for calibration of pulse to generate state 2 #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-pasquale
added
do not merge
Soft warning to avoid merging a PR for reason provided in the PR
deploy on hardware
labels
Sep 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 95.95% 96.02% +0.06%
==========================================
Files 88 90 +2
Lines 5939 6062 +123
==========================================
+ Hits 5699 5821 +122
- Misses 240 241 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
andrea-pasquale
added
the
qibolab release required
PR requires qibolab feature not available in the current poetry.lock
label
Sep 27, 2023
andrea-pasquale
removed
the
qibolab release required
PR requires qibolab feature not available in the current poetry.lock
label
Oct 5, 2023
4 tasks
andrea-pasquale
removed
the
do not merge
Soft warning to avoid merging a PR for reason provided in the PR
label
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise it all seems correct to me. I'll do some tests tomorrow.
Edoardo-Pedicillo
approved these changes
Oct 23, 2023
GabrielePalazzo
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two protocols:
Checklist:
master
main
main