Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protocol for calibration of pulse to generate state 2 #539

Merged
merged 19 commits into from
Oct 23, 2023

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Sep 27, 2023

This PR adds two protocols:

  • Qubit spectroscopy EF to estimate the frequency of the 1->2 transition (or the anharmonicity)
  • Rabi amplitude EF to calibrate the amplitude necessary to produce state 2 starting from 1

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@andrea-pasquale andrea-pasquale added do not merge Soft warning to avoid merging a PR for reason provided in the PR deploy on hardware labels Sep 27, 2023
@andrea-pasquale andrea-pasquale self-assigned this Sep 27, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #539 (86c6741) into main (e322b4e) will increase coverage by 0.06%.
The diff coverage is 99.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   95.95%   96.02%   +0.06%     
==========================================
  Files          88       90       +2     
  Lines        5939     6062     +123     
==========================================
+ Hits         5699     5821     +122     
- Misses        240      241       +1     
Flag Coverage Δ
unittests 96.02% <99.22%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/qibocal/protocols/characterization/__init__.py 100.00% <100.00%> (ø)
.../qibocal/protocols/characterization/allxy/allxy.py 100.00% <100.00%> (ø)
src/qibocal/protocols/characterization/rabi/ef.py 100.00% <100.00%> (ø)
...c/qibocal/protocols/characterization/rabi/utils.py 100.00% <100.00%> (ø)
...racterization/two_qubit_interaction/cz_virtualz.py 96.24% <100.00%> (-0.03%) ⬇️
src/qibocal/update.py 95.65% <100.00%> (+0.19%) ⬆️
...rotocols/characterization/qubit_spectroscopy_ef.py 98.50% <98.50%> (ø)

@andrea-pasquale andrea-pasquale added the qibolab release required PR requires qibolab feature not available in the current poetry.lock label Sep 27, 2023
@andrea-pasquale andrea-pasquale removed the qibolab release required PR requires qibolab feature not available in the current poetry.lock label Oct 5, 2023
@andrea-pasquale andrea-pasquale changed the base branch from main to chevron-couplers October 6, 2023 17:04
Base automatically changed from chevron-couplers to main October 9, 2023 12:24
@scarrazza scarrazza added this to the Qibocal 0.0.5 milestone Oct 10, 2023
@andrea-pasquale andrea-pasquale removed the do not merge Soft warning to avoid merging a PR for reason provided in the PR label Oct 12, 2023
@andrea-pasquale
Copy link
Contributor Author

Tested on qw5q_gold.

image

image

Seems to be working as expected! We should be able to produce state 2 now.

Copy link
Contributor

@GabrielePalazzo GabrielePalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise it all seems correct to me. I'll do some tests tomorrow.

@andrea-pasquale andrea-pasquale added the enhancement New feature or request label Oct 23, 2023
@andrea-pasquale andrea-pasquale added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 6d00390 Oct 23, 2023
21 checks passed
@andrea-pasquale andrea-pasquale deleted the w12_protocol branch October 23, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants