-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove onnx dep #1025
Remove onnx dep #1025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import onnxruntime as rt |
?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
- Coverage 97.50% 97.30% -0.21%
==========================================
Files 124 120 -4
Lines 9833 9747 -86
==========================================
- Hits 9588 9484 -104
- Misses 245 263 +18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you remember why we have both a qubit and Qblox fit?
The Qblox fit seems the simpler version of the qubit one, which is also doing fewer things (but most likely could be simplified a bit anyhow).
I'm not asking to do anything in this PR, or urgently. But if it's redundant we may have an issue for their deduplication.
It came out after a discussion with the lab people to benchmark with the qubit fit method. For sure we can remove it, I will open an issue EDIT: #1030 |
Checklist:
master
main
main