Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove onnx dep #1025

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Remove onnx dep #1025

merged 3 commits into from
Oct 29, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (5ff3d90) to head (d433967).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   97.50%   97.30%   -0.21%     
==========================================
  Files         124      120       -4     
  Lines        9833     9747      -86     
==========================================
- Hits         9588     9484     -104     
- Misses        245      263      +18     
Flag Coverage Δ
unittests 97.30% <100.00%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/qibocal/fitting/classifier/run.py 97.47% <ø> (ø)
src/qibocal/protocols/classification.py 94.05% <ø> (-5.95%) ⬇️
src/qibocal/protocols/qutrit_classification.py 100.00% <100.00%> (+2.43%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@alecandido alecandido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember why we have both a qubit and Qblox fit?

The Qblox fit seems the simpler version of the qubit one, which is also doing fewer things (but most likely could be simplified a bit anyhow).

I'm not asking to do anything in this PR, or urgently. But if it's redundant we may have an issue for their deduplication.

@Edoardo-Pedicillo
Copy link
Contributor Author

Edoardo-Pedicillo commented Oct 28, 2024

Do you remember why we have both a qubit and Qblox fit?

It came out after a discussion with the lab people to benchmark with the qubit fit method. For sure we can remove it, I will open an issue

EDIT: #1030

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 74d2625 Oct 29, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the remove_onnx branch October 29, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants