[Backport release-3_40] [elevation Profile] Correctly add a raster layer to an existing elevation profile widget #59830
+37
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an elevation profile widget is already open, when a new raster layer is added, it is not added to the elevation widget treeview. Indeed, when a new raster is added, `QgsRasterLayer::elevationProperties::hasElevation()` returns `False` by default and the proxy model of the elevation filters out the layers which do not have an elevation. Later on, `QgsAppLayerHandling::postProcessAddedLayer` is called on this raster and it sets the elevation to `True` if it looks like a DEM (See `QgsRasterLayerElevationProperties::layerLooksLikeDem()`). However, the layer tree of the elevation widget has already been populated and it is not updated. This issue is fixed by emitting the the `dataChanged` signal every time the elevation properties of a layer changes. Indeed, this forces a full refresh of the model and displays the raster in that case.
🪟 Windows buildsDownload Windows builds of this PR for testing. 🪟 Windows Qt6 buildsDownload Windows Qt6 builds of this PR for testing. |
jef-n
changed the title
nyalldawson
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #59809
Authored by: @ptitjano