Native JSON support for response serializing/deserializing long int (BigInt) #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rendez
force-pushed
the
feat/merino/json-parse-with-source-big-int
branch
from
ddb9eff
to
d22bd94
Compare
Rendez
force-pushed
the
feat/merino/json-parse-with-source-big-int
branch
from
868af22
to
9246857
Compare
kartik-gupta-ij
approved these changes
Feb 21, 2024
Rendez
force-pushed
the
feat/merino/json-parse-with-source-big-int
branch
from
c6b26c5
to
be8e78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6
closes qdrant/qdrant-web-ui#87
Implement TC39's stage 3 proposal JSON parse with source to serialize/deserialize big numeric values:
Learn more: https://2ality.com/2022/11/json-parse-with-source.html
Works in Chrome >= 112 or Node >= 20 with harmony flag:
--harmony-json-parse-with-source. That means, if BigInt is required, then it should be run in a supporting JS engine. Adoption will happen fast (months), so it's not a blocker if it's well documented.TODO
uint64need to be a union withbiginttypes.