Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove bulky dependencies #13

Merged
merged 2 commits into from
Oct 4, 2023
Merged

remove bulky dependencies #13

merged 2 commits into from
Oct 4, 2023

Conversation

generall
Copy link
Member

@generall generall commented Oct 3, 2023

  • remove optimum
  • more test + ci on other OS
  • fix batching embed

Performance of the current branch:

Huggingface Transformers (Average, Max, Min): (0.1034623384475708, 0.10434174537658691, 0.10258293151855469)
FastEmbed (Average, Max, Min): (0.06690812110900879, 0.06795573234558105, 0.06586050987243652)

and my venv directory is now only 200Mb instead of 5Gb for optimum.

@generall generall requested a review from NirantK October 3, 2023 19:22
@generall generall merged commit fa8684f into main Oct 4, 2023
12 checks passed
@generall generall deleted the 0.5-suggestions branch October 4, 2023 08:04
This was referenced Oct 8, 2023
Merged
Merged
@nleroy917 nleroy917 mentioned this pull request Nov 7, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NirantK NirantK NirantK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@generall @NirantK