WebUI: Implement server-side filtering, sorting and limit/offset.

[glassez]

Now you can use json/torrents request with filter parameter to retrieve filtered torrents.
Example: http://localhost:8080/json/torrents?filter=active

[sorokin]

I don't like the idea of having two functions QTorrentHandle::eta() and QBtSession::getETA() with a different meaning.

If QTorrentHandle::eta() is used only in WebUI, perhaps it should stay in WebUI. Also this looks suspiciusly similar to case TR_ETA in TorrentModelItem::data(). Perhaps the code should be shared?

[sorokin]

To summarize my comments in code: I don't like the idea of moving WebUI-specific functions to QTorrentHandle, while leaving NormalUI counter parts in TorrentModel.

[glassez]

To summarize my comments in code: I don't like the idea of moving WebUI-specific functions to QTorrentHandle, while leaving NormalUI counter parts in TorrentModel.

Is QTorrentHandle::torrentState() a WebUI-specific function?
The fact that other similar features are scattered throughout the qBittorrent code, does not mean that you need to do in the future.
I have some comments on the application architecture. I will say, when organize.

What is the point of this class? Why not using simple enum?

A class encapsulates data and functions of the processing (in this case, a numeric status value and a conversion function to a string). OOP :)

[buinsky]

Server side filtering must support filter by label for future release labels in WebUI.

[glassez]

I thought about it. Will do later.

[glassez]

Server side filtering must support filter by label for future release labels in WebUI.

Implemented now. Example: http://localhost:8080/json/torrents?filter=active&label=Soft or with empty label (label=) for "no label" or without label for "any label".

[sorokin]

Is QTorrentHandle::torrentState() a WebUI-specific function?
The fact that other similar features are scattered throughout the qBittorrent code, does not mean that you need to do in the future.

Then I should be shared with TorrentModel. I don't see why moving it to QTorrentHandle without sharing is a good idea.

[glassez]

Yes. Sharing is a good idea.It is a VERY good idea.
But I can't cover all the code at once. So far, I've just moved into QTorrentHandle class part of the functionality that should be in it.

[sledgehammer999]

Heads up: Currently it isn't mergable cleanly.
(I hope this weekend I'll review it).

[sledgehammer999]

I think I am done with the review.
PS: If Qt Creator gives you trouble with indentation, leave it as is. It isn't too important.

[sledgehammer999]

@glassez github says that this isn't mergable cleanly...

[glassez]

It's all because of commits that corrects the indentation.
Apparently, it is better not to include them in other pull-requests, and to present separately, and there are persistent problems with rebasing.

[sledgehammer999]

Thank you the code.